Repository navigation
Remove the forwards of moved modules - #121
Merged
Merged
Conversation
hermit.agents, hermit.evolver, hermit.llm, hermit.backends and hermit.trajectory forwarded for 0.2 only; hermit.agent.base.direct, hermit.agent.base.container and hermit.agent.environment were added this release and never shipped. Nothing in the repository imports them. hermit/_moved.py goes with them. The docs, the CHANGELOG and the Docker comments name the new paths; a test checks the old ones are gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…is missing The CHANGELOG lists each removed path with its new one, hermit.agents' submodules included, and no longer calls hermit.agent.base.direct and hermit.agent.base.container unreleased: they were 0.2's modules. The test checks the ModuleNotFoundError names the old module, so a forward left behind without its helper fails it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
hermit/had bothagent/andagents/;agents/and seven modules like it only forwarded old import paths towhere the code moved. Nothing in the repository imports them any more. This removes all eight and the helper they
used,
hermit/_moved.py:hermit.agents(.base,.cli,.react,.tools,.container,.login)hermit.agent.acting(.agent,.workspace,.react,.tools),hermit.environment.docker,hermit.agent.base.loginhermit.evolverhermit.agent.evolverhermit.llm,hermit.backendshermit.agent.model.llm,hermit.agent.model.backendshermit.trajectoryhermit.agent.base.trajectoryhermit.agent.base.directhermit.agent.model.directhermit.agent.base.containerhermit.environment.dockerhermit.agent.environmenthermit.environmentThe first five were 0.1's paths, forwarded in 0.2 only.
hermit.agent.base.directandhermit.agent.base.containerwere 0.2's modules, moved this release; by decision their forwards go too, with no release that warns first: code
outside the repository that imports them from 0.2 fails with
ModuleNotFoundErrorand the CHANGELOG names the newpath.
hermit.agent.environmentwas never released.Core changes: only the forwarding modules; no implementation changes. Documentation: CHANGELOG (Unreleased,
Breaking: the table above, submodules included),
docs/framework/agent-layers.md(the forwards are gone),tests/selection.py(the removed paths), and the path in three Docker comments.Validation
python -m pytest tests/core/test_task.py tests/core/test_selection.py tests/core/test_layers.py: 26 passed.test_the_moved_modules_old_paths_are_gone(8 cases, 0.14 s) asserts each old path raisesModuleNotFoundErrorfor that module itself. Onmainall 8 fail; with one forward put back but_moved.pygone,it fails too.
hermitmodule: none fails on a removed path. Searchedhermit/,examples/,tests/,docs/,docker/, the YAML configs andpyproject.toml's entry point for the old paths (python -m hermit.backendslaunchers included): none left outside the CHANGELOG's history.
git diff --checkpassed. Not run: the full suite (no implementation changed); CI runs it.Review
each new path.
model calls through Layer 1, where an agent runs is its environment, a benchmark's own agent subclasses a core
agent in its example folder. No agent is added or changed;
tests/core/test_layers.pypassed.General checklist:
hermit/_moved.py; no implementation changes (Change).the repository uses one (Validation).
importlib.import_module);the console script and the
python -m hermit.agent.model.backendslaunchers still run.docs/framework/agent-layers.md,tests/selection.pyand three Docker comments.a7b68e57againstthe general and test checklists. It confirmed no remaining caller and found two defects, both fixed in
a30e62f9: the CHANGELOG left out wherehermit.agents' submodules went, and the test passed when a forwardremained but its helper was gone (it now checks the missing module's name). Its question, that
hermit.agent.base.directandhermit.agent.base.containerwere 0.2's modules and not this release's forwardsonly, is answered in Change: removed by decision, and the description no longer calls them unreleased.
a30e62f9itself (the CHANGELOG table and the test's name check) was not re-audited.Test checklist (
test_the_moved_modules_old_paths_are_gone):tests/core/test_task.py, which--changedselects for this change; no new helper orfixture.
ModuleNotFoundErrora caller sees, for the old module itself. All 8 cases fail onmain, and a forward put back without_moved.pyfails it.importlib.import_module, as any caller's import; no stand-ins.warningsimport removed; nothing started.🤖 Generated with Claude Code